Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CXXFLAGS=-Wp,-D_GLIBCXX_ASSERTIONS to the gcc-9 build in Travis CI #275

Closed

Conversation

esabol
Copy link
Member

@esabol esabol commented Feb 18, 2020

As discussed in issue #272, ensure C++ STL is used properly, according to _GLIBCXX_ASSERTIONS. This only adds it to the gcc-9 build. Let me know if you think it should be added to other gcc/g++ builds.

Reference:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html

@esabol
Copy link
Member Author

esabol commented Feb 18, 2020

Do not merge this. I must have done something wrong. The gcc/g++-9 build should have failed with _GLIBCXX_ASSERTIONS.

@SpamapS
Copy link
Member

SpamapS commented Feb 18, 2020

Ed you can reopen if/when it's safe. Just don't want us to accidentally merge something weird. :)

@esabol
Copy link
Member Author

esabol commented Feb 21, 2020

Ed you can reopen if/when it's safe.

I don't see a button to reopen it?

I figured it out and have tested it here:
https://travis-ci.org/esabol/gearmand/jobs/653268979

This build also crashes t/unittest, which is interesting. @cheese didn't report seeing that on Fedora 31.

@esabol
Copy link
Member Author

esabol commented Feb 21, 2020

This build also crashes t/unittest, which is interesting. @cheese didn't report seeing that on Fedora 31.

Oh, that's the libtest/http.cc issue. Never mind. It's all good. I'll rebase this PR once PR #281 is merged, and the gcc-9/g++-9 build should work again.

@p-alik
Copy link
Collaborator

p-alik commented Feb 21, 2020

I don't see a button to reopen it?

You'll need at least contributor permissions to reopen an issue.
@SpamapS, could you grant it to @esabol?

@SpamapS
Copy link
Member

SpamapS commented Feb 25, 2020 via email

@esabol
Copy link
Member Author

esabol commented Mar 4, 2020

This PR is blocked by PR #281, fwiw. (Edited. Sorry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants