Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gtest): Introduce reservations for the gtest #4089

Merged
merged 9 commits into from
Aug 1, 2024
Merged

feat(gtest): Introduce reservations for the gtest #4089

merged 9 commits into from
Aug 1, 2024

Conversation

techraed
Copy link
Member

@techraed techraed commented Jul 26, 2024 •
edited
Loading

Release notes: introducing gas reservations creation/deletion and usage for message sending on gtest.

TODO:

  • implement reserve_gas
  • implement unreserve_gas
  • implement message sending from reservations

@techraed techraed added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities labels Jul 26, 2024
@techraed techraed self-assigned this Jul 26, 2024
@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jul 29, 2024
ByteNacked
ByteNacked reviewed Jul 31, 2024
View reviewed changes
gtest/src/manager.rs Outdated Show resolved Hide resolved
@ByteNacked
Copy link
Member

ByteNacked commented Jul 31, 2024 •
edited
Loading

LGTM 👍

ark0f
ark0f approved these changes Jul 31, 2024
View reviewed changes
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/program.rs Outdated Show resolved Hide resolved
@techraed techraed mentioned this pull request Aug 1, 2024
Closed
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Aug 1, 2024
@techraed techraed merged commit 2a8a985 into master Aug 1, 2024
18 checks passed
@techraed techraed deleted the st-reservations-gtest branch August 1, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteNacked ByteNacked ByteNacked approved these changes

@ark0f ark0f ark0f approved these changes

@playX18 playX18 playX18 approved these changes

@breathx breathx Awaiting requested review from breathx

Assignees

@techraed techraed

Labels
A2-mergeoncegreen PR is ready to merge after CI passes B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@techraed @ByteNacked @ark0f @playX18