Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasmer version #4037

Merged
merged 64 commits into from
Jul 30, 2024
Merged

Update wasmer version #4037

merged 64 commits into from
Jul 30, 2024

Conversation

ByteNacked
Copy link
Member

@ByteNacked ByteNacked commented Jul 2, 2024 •
edited by gshep
Loading

Resolves #2934.

Update Wasmer version to latest release (v4.3.2)

  • This Wasmer version was fuzzed with the lazy pages fuzzer (to ensure absence of UB) for ~1 week.
  • Resynced the Vara history successfully

@reviewer-or-team

@ByteNacked ByteNacked self-assigned this Jul 2, 2024
@ByteNacked ByteNacked marked this pull request as draft July 2, 2024 10:59
@ByteNacked ByteNacked force-pushed the rmasl-update-wasmer-version branch from 5c06888 to 94e1fb1 Compare July 6, 2024 21:44
@ByteNacked
Copy link
Member Author

Waiting for one more review/approval @grishasobol @gshep

@ByteNacked ByteNacked requested a review from gshep July 18, 2024 18:08
@ByteNacked
Copy link
Member Author

Update:

  • After discussion renamed some entities in sandbox-host crate
  • Refactored/simplified code a little bit, move access to gas_global into FunctionEnv
  • Added same store check in StoreRefCell

gshep
gshep approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 💯

Cargo.toml Show resolved Hide resolved
sandbox/host/src/sandbox.rs Outdated Show resolved Hide resolved
sandbox/host/src/sandbox.rs Outdated Show resolved Hide resolved
sandbox/host/src/sandbox/wasmer_backend/store_refcell.rs Outdated Show resolved Hide resolved
grishasobol
grishasobol approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to make full sync once more, in order to be sure that nothing was broken in latest changes. This can be done after merging in master, but before next release.

sandbox/host/src/sandbox/wasmer_backend.rs Outdated Show resolved Hide resolved
@ByteNacked ByteNacked merged commit e917669 into master Jul 30, 2024
10 checks passed
@ByteNacked ByteNacked deleted the rmasl-update-wasmer-version branch July 30, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@grishasobol grishasobol grishasobol approved these changes

@StackOverflowExcept1on StackOverflowExcept1on Awaiting requested review from StackOverflowExcept1on

@ark0f ark0f Awaiting requested review from ark0f

@breathx breathx Awaiting requested review from breathx

Assignees

@ByteNacked ByteNacked

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wasmer to 4.0 in gear_sandbox
5 participants
@ByteNacked @NikVolf @gshep @grishasobol @breathx