Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump rust version to latest nightly #3571

Merged
merged 20 commits into from
Feb 2, 2024
Merged

chore: bump rust version to latest nightly #3571

merged 20 commits into from
Feb 2, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Dec 7, 2023 •
edited
Loading

Resolves #3452

TODO:

  • check some stuff related to clippy
  • find more stable version

@StackOverflowExcept1on StackOverflowExcept1on added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed A4-insubstantial Not too important PR labels Dec 7, 2023
shamilsan
shamilsan approved these changes Dec 11, 2023
View reviewed changes
common/numerated/src/interval.rs Show resolved Hide resolved
techraed
techraed reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it fixed all the stuff related to fuzzer and coverage?

@StackOverflowExcept1on
Copy link
Member Author

@SabaunT yes, this PR fixes:

  1. error[E0275]: overflow evaluating the requirement '<Runtime as pallet_grandpa::Config>::KeyOwnerProof == _'
  2. Malformed coverage data with a no_mangle function rust-lang/rust#117788

@StackOverflowExcept1on
Copy link
Member Author

StackOverflowExcept1on commented Dec 12, 2023 •
edited
Loading

but this should not be merged until rust-lang/rust-clippy#11953
also locking_gas_for_waitlist fails for some reason

@StackOverflowExcept1on StackOverflowExcept1on added the A5-dontmerge PR should not be merged yet label Dec 12, 2023
@StackOverflowExcept1on StackOverflowExcept1on marked this pull request as ready for review December 30, 2023 15:52
@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team and removed A4-insubstantial Not too important PR A5-dontmerge PR should not be merged yet A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Dec 30, 2023
@breathx
Copy link
Member

breathx commented Jan 8, 2024

Re-open once fuzzer works well

@breathx breathx closed this Jan 8, 2024
breathx
breathx approved these changes Feb 1, 2024
View reviewed changes
gclient/src/api/listener/mod.rs Show resolved Hide resolved
gclient/src/lib.rs Show resolved Hide resolved
gstd/src/macros/debug.rs Show resolved Hide resolved
runtime/vara/src/lib.rs Show resolved Hide resolved
@breathx breathx requested a review from techraed February 1, 2024 09:44
@breathx
Copy link
Member

breathx commented Feb 1, 2024

Btw dont we want just whitelist #[allow(static_mut_ref)] ?
We have single thread guarantees here

@StackOverflowExcept1on StackOverflowExcept1on added the A2-mergeoncegreen PR is ready to merge after CI passes label Feb 1, 2024
@StackOverflowExcept1on StackOverflowExcept1on merged commit a1c7bf7 into master Feb 2, 2024
10 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/rust-1.76-support branch February 2, 2024 16:50
breathx pushed a commit that referenced this pull request Feb 27, 2024
@StackOverflowExcept1on @breathx
chore: bump rust version to latest nightly (#3571)
2456d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@shamilsan shamilsan shamilsan approved these changes

@techraed techraed techraed approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove false positive clippy lint on next rust update
4 participants
@StackOverflowExcept1on @breathx @techraed @shamilsan