-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace reply data tuple with struct #1198
Conversation
cb9979aPallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
bbbc634Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
|
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
+ Coverage 72.09% 72.11% +0.02%
==========================================
Files 107 107
Lines 9932 9949 +17
==========================================
+ Hits 7160 7175 +15
- Misses 2772 2774 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like using structs instead of tuples in such kind of circumstances 👍
Message
s reply now contains special named struct instead of just tuple(MessageId, ExitCode)
. This increases readability of events in scanners like polkadot js apps@gear-tech/dev