Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest gdsfactory #55

Merged
merged 10 commits into from
Jan 15, 2023
Merged

update to latest gdsfactory #55

merged 10 commits into from
Jan 15, 2023

Conversation

joamatab
Copy link
Contributor

update

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 14, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 2.95 ⭐ 2.97 ⭐ 0.02 👎
Method Length 691.25 ⛔ 693.17 ⛔ 1.92 👎
Working memory 21.97 ⛔ 21.96 ⛔ -0.01 👍
Quality 49.53% 😞 49.47% 😞 -0.06% 👎
Other metrics Before After Change
Lines 1716 1714 -2
Changed files Quality Before Quality After Quality Change
docs/conf.py 77.95% ⭐ 77.62% ⭐ -0.33% 👎
docs/write_components_doc.py 39.39% 😞 37.49% 😞 -1.90% 👎
sky130/__init__.py 54.58% 🙂 54.58% 🙂 0.00%
sky130/layers.py 61.54% 🙂 61.54% 🙂 0.00%
sky130/pcells/nmos.py 26.95% 😞 26.93% 😞 -0.02% 👎
sky130/pcells/pmos.py 26.95% 😞 26.95% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
sky130/pcells/nmos.py nmos 8 ⭐ 2380 ⛔ 55 ⛔ 25.50% 😞 Try splitting into smaller methods. Extract out complex expressions
sky130/pcells/pmos.py pmos 8 ⭐ 2380 ⛔ 55 ⛔ 25.50% 😞 Try splitting into smaller methods. Extract out complex expressions
sky130/layers.py get_layer_stack_generic 0 ⭐ 354 ⛔ 8 🙂 56.07% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #55 (be263fa) into main (89b3e91) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          20       20           
  Lines        5677     5677           
=======================================
  Hits         4552     4552           
  Misses       1125     1125           
Impacted Files Coverage Δ
sky130/pcells/nmos.py 81.16% <0.00%> (ø)
sky130/pcells/pmos.py 81.16% <ø> (ø)
sky130/__init__.py 88.88% <100.00%> (ø)
sky130/layers.py 99.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit d37f19e into main Jan 15, 2023
@joamatab joamatab deleted the 040 branch March 6, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant