Skip to content

Commit

Permalink
Merge pull request #31 from gdsfactory/fix_jupyter
Browse files Browse the repository at this point in the history
fix server_jupyter
  • Loading branch information
sebastian-goeldi authored Aug 31, 2023
2 parents 70fe03a + bfb715c commit 6132f73
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 65 deletions.
48 changes: 24 additions & 24 deletions .github/workflows/test_code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,28 +54,28 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
test_docs:
needs: [pre-commit]
runs-on: ${{ matrix.os }}
strategy:
max-parallel: 12
matrix:
python-version: ['3.10']
os: [ubuntu-latest]
# test_docs:
# needs: [pre-commit]
# runs-on: ${{ matrix.os }}
# strategy:
# max-parallel: 12
# matrix:
# python-version: ['3.10']
# os: [ubuntu-latest]

steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
sudo apt install pandoc
make install
pip install -e .[docs]
- name: Test documentation
run: |
cd docs
make html
# steps:
# - uses: actions/checkout@v3
# - name: Set up Python
# uses: actions/setup-python@v4
# with:
# python-version: '3.11'
# - name: Install dependencies
# run: |
# python -m pip install --upgrade pip
# sudo apt install pandoc
# make install
# pip install -e .[docs]
# - name: Test documentation
# run: |
# cd docs
# make html
39 changes: 0 additions & 39 deletions Makefile

This file was deleted.

2 changes: 1 addition & 1 deletion src/kweb/default.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .browser import get_app
from kweb.browser import get_app

app = get_app()
2 changes: 1 addition & 1 deletion src/kweb/server_jupyter.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# import requests
import uvicorn

from kweb.main import app
from kweb.default import app

global jupyter_server
jupyter_server = None
Expand Down

0 comments on commit 6132f73

Please sign in to comment.