Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json updates, fix typos in README.md and add some missing type annotations tsc was complaining about #106

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

darcyparker
Copy link
Contributor

@darcyparker darcyparker commented Mar 13, 2023

See commit comments.

  • The package-lock.json was out of date. And I noticed some npm audit vulnerabilities and some outdated packages. So I made updates.
  • I also fixed a few minor typos in the README.md
  • And I noticed some missing type annotations. These types were specified in jsdoc, but not as typescript return types.

I just noticed (after the fact) that you have a bunch of PRs created by bot that were probably automated. I think it is better to take this PR because I did the updates carefully by hand with a combination of npm install and npm audit fix...

@darcyparker
Copy link
Contributor Author

Note: I chose node v16 for .node-version and .nvmrc because there are breaking changes in v17...

You may have some feedback for engines in package.json and want to support a wider range?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant