Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session ratings #690

Merged
merged 22 commits into from
Jan 5, 2020
Merged

Session ratings #690

merged 22 commits into from
Jan 5, 2020

Conversation

abraham
Copy link
Member

@abraham abraham commented Jan 5, 2020

Closes #617

This takes the great work that @radi-cho did and expands on it a little.

  • Splits the rating into styleRating and contentRating. I think it's good to give presenters some additional feedback presentation style vs slide content.
  • Adds some Firestore data validation and tests

@abraham abraham requested a review from pearlbea January 5, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants