Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #666

Merged
merged 10 commits into from
Sep 26, 2019
Merged

Cleanup #666

merged 10 commits into from
Sep 26, 2019

Conversation

abraham
Copy link
Member

@abraham abraham commented Sep 25, 2019

Speaker details dialog tags

before after
tags-before tags--after

Handle missing company our location

before after
subtitle-before subtitle-after

Fix latest news card top border radius

before after
news-card-before news-card-after

Add border radius to location details

before after
location-block-before location-after

Remove card design from partners

before after
sponsors-before sponsors-after

Add bottom margin to tags in filter dropdown

before after
filter-before filter-after
  • cleanup faq formatting ( new lines, extra spaces)
  • Remove hero copy
  • Sort partners client side (sorting in the DB will not return partners that do not have an order value)
  • Sort filter tags alphabetically

Copy link
Collaborator

@pearlbea pearlbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about the FAQ content. It seems specific to GDG Ukraine. Is the idea that every user will replace this with their own content?

data/faq.md Show resolved Hide resolved
data/faq.md Show resolved Hide resolved
@abraham
Copy link
Member Author

abraham commented Sep 26, 2019

FAQ content should be made more generic but this PR just changes whitespace in the FAQ so that should happen later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants