Move to Firebase hosting. Remove server code. #102
Conversation
…epeat` Fix some styling issues (more to do still) Refactor routing, components, and asset locations. Remove empty files. Added in some one time bindings for performance. Filter in controller as much as possible for performance.
Use minified version of ngGeolocation. Bump version of ngGeolocation.
Sometimes this was being stored in the $scope which wasn't always visible and caused duplication of data. Update to Angular Material 1.0.0.
Conflicts: server/routes.js
update dependencies fix grunt copy task to copy image assets to `dist/` properly
Remove old dependencies from server. Fixes #55.
fix JSCS failures remove excess server requests and more code that assumes that the URL will be prefixed
add BrowserSync config for use with lite-server add `local.env.sample.js` with instructions for configuring keys locally remove UrlShortener docs update local dev and production deployment steps update License years
| <md-list-item class="md-2-line" ng-repeat="event in allEvents | orderBy:distanceFromHere | limitTo:5" | ||
| ng-click="openEvent(event._id)"> | ||
| <md-list-item class="md-2-line" ng-repeat="event in vm.nearEvents | limitTo:5" | ||
| ng-click="vm.openEvent(event._id)"> |
There was a problem hiding this comment.
Noob question. What does vm stand for?
There was a problem hiding this comment.
ViewModel or Controller. Angular 1.x style guide uses vm and Angular 2 style guide has switched to $ctrl.
|
I wonder what do we think about the subdomain? Does Firebase provide ssl for subdomains? If so, we can keep the old url structure right? |
|
@tasomaniac I don't think that Firebase supports HTTPS for subdomains unless you want to deploy a separate Firebase for each subdomain. That would be a nightmare to maintain though. |
|
I'm seeing some funky behavior on the The first 3 elements are repeating at the end and the sorting doesn't seem right. I'll try to look into it later. |
|
Looks good to me. You can merge it once you fixed the problem. |
also fixed repeated items in md-virtual-repeat caused by one-time bindings fix exception on event page if event doesn't have geo data
i.e. it should ask the Hub for upcoming events only
|
OK, fixed the odd behavior of repeating elements in md-virtual-repeat. Also fixed
|
|
The only remaining issue that I'm seeing is related to the Hub. Sometimes I'm not getting back all of the results that I would expect querying for a tag like DevFest for upcoming events. I'm investigating that separate from this PR. |
|
👍 Great work. |
|
This looks like it will save about $70 per month on GCP hosting costs. Perhaps more when counting static IP and load balancer, etc. |
gdg.events/android/eventsinstead ofandroid.gdg.events.Please check it out here: https://firefly-1c312.firebaseapp.com/ and https://gdg.events/
Fixes #26, #58, #97, #80, #81.
Closes #82, #101, #96.