Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Use Material design #18

Closed
friedger opened this issue Sep 29, 2014 · 13 comments
Closed

Use Material design #18

friedger opened this issue Sep 29, 2014 · 13 comments
Assignees
Milestone

Comments

@friedger
Copy link
Contributor

As suggested by Oleh
https://github.com/FezVrasta/bootstrap-material-design

@Splaktar
Copy link
Contributor

Another one to look at is: https://github.com/angular/material

@samcarecho
Copy link
Contributor

I'm in to help with the matter.

I've been reading the angular materials documentation and from what I saw there, we might be able to refactor all that is needed during the "Code for GDG[X] event.

Let's make our priority to use "Responsive Flex" on the refactoring.


More info:

I've started working on a new design for FireFly using angular-material.
I'm replacing bootstrap and JQuery. Any thoughts, suggestions or ideas?

Can someone create a new branch called "firefly-material"?

@stefanhoth
Copy link
Contributor

Is that closable with the merge #27?

@mauimauer
Copy link
Member

I'd say that PR is rather incomplete.

@stefanhoth
Copy link
Contributor

ok, just checking for housekeeping.

@Splaktar
Copy link
Contributor

Splaktar commented Mar 2, 2015

It's still using angular-material ~0.5.1. 0.8.2 was just released and 0.9.0 is coming out soon. There are many new changes and some breaking changes between 0.5.1 and the latest. But there are many significant improvements. I may be able to help out with this after I finish upgrading boomerang to angular-material (in progress). I've been using angular-material at work for the last 4 months or so.

@Splaktar
Copy link
Contributor

I've updated the master branch to clean this up a bit so that it will display the map with angular-material 0.9.0 and generally layout the site properly. This was done via PR #36 but more needs to be done. Please refer to that PR's screenshots and let me know if you have a preference for the default header color.

I've opened issue #37 to track some improvements that are needed for the Header.

@Splaktar Splaktar self-assigned this May 17, 2015
@Splaktar
Copy link
Contributor

PR #41 fixes the material design layouts for the individual event pages.

What remains to do here?

  • Rip out all remnants of Bootstrap (still in use for some styling and things like pull-right)
  • Lots of general HTML cleanup and styling improvements (probably out of scope for this issue)
  • What else?

@Splaktar Splaktar added this to the 1.2 milestone Jun 20, 2015
@Splaktar
Copy link
Contributor

The footer isn't sticking well to the bottom atm due to Bootstrap issues. This should be resolved once Bootstrap is pulled out and Angular Material's flexbox layouts can be used.

@Splaktar Splaktar modified the milestones: 1.2, 1.3 Sep 27, 2015
@Splaktar
Copy link
Contributor

Splaktar commented Oct 2, 2015

I'm pretty close to being able to completely remove Bootstrap, jQuery, and ui-bootstrap from the project. I'm also cleaning up a ton of styling and unused images. The project should be a lot slimmer very soon!

@tasomaniac
Copy link
Member

That's a great news 👍

On Fri, Oct 2, 2015, 6:18 PM Michael Prentice [email protected]
wrote:

I'm pretty close to being able to completely remove Bootstrap, jQuery, and
ui-bootstrap from the project. I'm also cleaning up a ton of styling and
unused images. The project should be a lot slimmer very soon!


Reply to this email directly or view it on GitHub
#18 (comment).

@Splaktar
Copy link
Contributor

Splaktar commented Oct 5, 2015

OK, going to submit a PR for the main page updates. I'll create a new PR for the event page updates when I have time.

@Splaktar
Copy link
Contributor

PR #69 should wrap up the remaining work on this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants