Honor manual requests for static linking #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a user to statically link a library even when not using pkg-config as source. Previously, if SYSTEM_DEPS_<LIB>_NO_PKG_CONFIG was set, the SYSTEM_DEPS_<LIB>_LINK=static configuration was ignored. Since the user already went above and beyond to issue a strong intent of static linking, no check is performed whether the file actually exists. The linker will scream if something is wrong.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 62.48% 62.97% +0.49%
==========================================
Files 3 3
Lines 3505 3565 +60
==========================================
+ Hits 2190 2245 +55
- Misses 1315 1320 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for your patch, and kudo for writing a test! ❤️ I just released |
Thanks :) |
Ablu
added a commit
to Ablu/libgpiod
that referenced
this pull request
Jun 26, 2023
Static linking simplifies the test execution a bit (no need to set LD_LIBRARY_PATH). system-deps had a bug with it when disabling pkg-config lookup [1]. Bump the lower floor to a version with the fix. API slightly changed regarding iterating the libs. No functional changes intended. Since this is only a build-dep, no implications should occur for users. [1] gdesmott/system-deps#75 Signed-off-by: Erik Schilling <[email protected]>
Ablu
added a commit
to Ablu/libgpiod
that referenced
this pull request
Jun 29, 2023
Static linking simplifies the test execution a bit (no need to set LD_LIBRARY_PATH). system-deps gained static linking support with version 4.0, but then had a bug with it when disabling pkg-config lookup [1]. Bump the lower floor to a version with the fix. So we can choose between 4.x or >6.1.x. In order to prevent needing to bump the MSRV, this goes with 4.x. API slightly changed regarding iterating the libs. No functional changes intended. Since this is only a build-dep, no implications should occur for users. [1] gdesmott/system-deps#75 Signed-off-by: Erik Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to statically link a library even when not using pkg-config as source. Previously, if SYSTEM_DEPS_NO_PKG_CONFIG was set, the SYSTEM_DEPS_LINK=static configuration was ignored.
Since the user already went above and beyond to issue a strong intent of static linking, no check is performed whether the file actually exists. The linker will scream if something is wrong.