Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor hessian fix #561

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Minor hessian fix #561

merged 4 commits into from
Oct 10, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Oct 10, 2024

DI source

  • Fuse the map and reduce(hcat/vcat) for Jacobian and Hessian. This makes jacobian and hessian type-unstable, see the MWE on Discourse. Not doing this change for now.
  • Get rid of two useless lines in hessian.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (f663225) to head (21a28f6).

❗ There is a different number of reports uploaded between BASE (f663225) and HEAD (21a28f6). Click for more details.

HEAD has 55 uploads less than BASE
Flag BASE (f663225) HEAD (21a28f6)
DI 66 24
DIT 16 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #561       +/-   ##
===========================================
- Coverage   98.39%   78.48%   -19.92%     
===========================================
  Files         107      105        -2     
  Lines        4739     4703       -36     
===========================================
- Hits         4663     3691      -972     
- Misses         76     1012      +936     
Flag Coverage Δ
DI 87.59% <100.00%> (-11.05%) ⬇️
DIT 59.25% <ø> (-38.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle added the skipci Don't run CI tests and docs label Oct 10, 2024
@gdalle gdalle changed the title Speed up Jacobian and Hessian with mapreduce Minor hessian fix Oct 10, 2024
@gdalle gdalle marked this pull request as ready for review October 10, 2024 11:22
@gdalle gdalle merged commit bd62b64 into main Oct 10, 2024
5 checks passed
@gdalle gdalle deleted the gd/mapreduce branch October 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skipci Don't run CI tests and docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants