Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CommonBigInteger/Decimal public #47

Open
MisterAssm opened this issue Aug 20, 2022 · 1 comment
Open

Make CommonBigInteger/Decimal public #47

MisterAssm opened this issue Aug 20, 2022 · 1 comment

Comments

@MisterAssm
Copy link

kt-math 0.7.0 cannot be a pure porting of java.math.* BigInteger and BigDecimal, representative classes, are marked as internal, the constructors are then not available to users.

So for example, the sign-magnitude representation of a BigInteger in a BigInteger cannot be called for the creation of a BigInteger (for an RSA Kotlin/JS implementation)

gciatto added a commit that referenced this issue Mar 7, 2023
@gciatto
Copy link
Owner

gciatto commented May 25, 2023

@MisterAssm I should have added for factories on the interfaces to address your issue.
Is that ok for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants