This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
gh-984: Change usage of log4j to slf4j #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #985 +/- ##
==========================================
Coverage ? 50.50%
Complexity ? 125
==========================================
Files ? 42
Lines ? 1596
Branches ? 130
==========================================
Hits ? 806
Misses ? 736
Partials ? 54 Continue to review full report at Codecov.
|
GCHQDeveloper314
approved these changes
Mar 25, 2022
They were actually required because slf4j logger doesn't let you just log an Object. But yes I am glad it got flagged as the usage is nicer now. |
t92549
added a commit
that referenced
this pull request
Mar 25, 2022
t92549
added a commit
that referenced
this pull request
May 12, 2023
* Revert "gh-951: Add deprecation note to readme (#952)" (#983) This reverts commit 94a4d38. * gh-984: Change usage of log4j to slf4j (#985) * gh-984: Change usage of log4j to slf4j * gh-984: Checkstyle * Updated Gaffer version to 1.22.0 (#990) * Updated Gaffer version to 1.22.0 * Gh-986: Migrate log4j to reload4j (#992) * gh-984: Change usage of log4j to slf4j * gh-984: Checkstyle * Exclude Log4j dependencies Co-authored-by: t92549 <[email protected]> * gh-975: Fix gafferpy alpha 1 (#994) Co-authored-by: Gaffer <[email protected]> Co-authored-by: GCHQDeveloper314 <[email protected]> * prepare release gaffer-tools-1.22.0 * prepare for next development iteration * Update links to point to v1docs (#999) * Graph layout is now saved when navigate away from page (#812) * Graph layout is now saved when navigate away from page * Fixed issue with old graph results still showing after clear * Updating removed elements to use concat * Updating to use forEach Updating removePreviouslyRemovedElements to use forEach * Updated syntax error * Altered foreach syntax due to jasmine errors * gh-496: Fix bug with concat Co-authored-by: t11947 <[email protected]> Co-authored-by: t92549 <[email protected]> * Add Deprecation message to UI README (#1061) * Updated Gaffer version to 1.23.0 (#1064) * Updated Gaffer version to 1.23.0 * CommonConstants replaced * Fixed js deps * Fixed js deps again * Original package.json --------- Co-authored-by: Gaffer <[email protected]> * prepare release gaffer-tools-1.23.0 * prepare for next development iteration --------- Co-authored-by: Gaffer <[email protected]> Co-authored-by: GCHQDeveloper314 <[email protected]> Co-authored-by: p013570 <[email protected]> Co-authored-by: t11947 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue