Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToGeohash and FromGeohash operations #344

Merged
merged 5 commits into from
Aug 29, 2018
Merged

Add ToGeohash and FromGeohash operations #344

merged 5 commits into from
Aug 29, 2018

Conversation

GCHQ77703
Copy link
Member

Adds the ngeohash library to the default bundle, which is ~300 lines of code and has no dependencies.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2018

CLA assistant check
All committers have signed the CLA.

@GCHQ77703
Copy link
Member Author

GCHQ77703 commented Aug 26, 2018

A geohash is a way of encoding a latitude and longitude into a single, interleaved string. You can set it to have an arbitrary precision. For example, GCHQ is located at gcnrr8j0e0w6 but you can also specify roughly the same place with just the string gcnrr. It is the storage system for coordinates used in Elasticsearch, MongoDB, HBase and Accumulo, as well as various others.

@GCHQ77703
Copy link
Member Author

Just discovered the wonderful fork operation.

@GCHQ77703
Copy link
Member Author

From the formatMacAddress module:

input.toLowerCase().split(/[,\s\r\n]+/);

I'm now unsure whether it's normal to handle a single input and expect the user to split it for us, or whether it's better for us to split it to save the user adding another module. If the latter is true, it is easy enough to just revert 001f3f3.

@n1474335
Copy link
Member

Thanks very much, this is great.

On the forking front, it really just depends on the operation. I think in this case it makes sense to split by line without forcing the user to use 'Fork' so I've added that functionality back in.

I also moved these ops into the 'Hashing' category as I think they fit there slightly better than 'Data format'. I also moved them into the Hashing module. I realise it's a small library, but I really don't want to add any more libraries into the Default module if I can possibly avoid it.

@n1474335 n1474335 merged commit 9113317 into gchq:master Aug 29, 2018
BRAVO68WEB pushed a commit to BRAVO68WEB/CyberChef that referenced this pull request May 29, 2022
…-issue

String to Bool for statusCheckAllowInsecure on save
Fixes gchq#344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants