Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves the horizontal padding issue with text fields in Android #329

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Solves the horizontal padding issue with text fields in Android #329

merged 1 commit into from
Mar 8, 2017

Conversation

danilvalov
Copy link
Contributor

Related issue: #327

@alvaromb alvaromb self-requested a review March 8, 2017 14:43
Copy link
Collaborator

@alvaromb alvaromb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should paddingHorizontal only live in 'android'? Does it look ok under iOS too?

@danilvalov
Copy link
Contributor Author

@alvaromb
This PR fixes your changes. Please, check it and tell me about any problems. We need to find a better way to solve issues #301 and #329.

@alvaromb
Copy link
Collaborator

alvaromb commented Mar 8, 2017

Oh, I see, didn't noticed about the paddingHorizontal/padding change.

The better way to solve these issues is to make the community more active into the project. Thanks for contributing, @danilvalov.

Copy link
Collaborator

@alvaromb alvaromb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@alvaromb
Copy link
Collaborator

alvaromb commented Mar 8, 2017

@gcanti horizontal padding is coming back to the stylesheet. Good to merge.

@gcanti gcanti merged commit b0488ac into gcanti:master Mar 8, 2017
@gcanti
Copy link
Owner

gcanti commented Mar 8, 2017

@alvaromb should I release a patch?

@alvaromb
Copy link
Collaborator

alvaromb commented Mar 8, 2017

Yes, a patch would be ok. People extending base stylesheet could be affected by #325.

@gcanti
Copy link
Owner

gcanti commented Mar 8, 2017

Patch released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants