Issue crc-org#838 Add virtualbox deprecation notice

gbraad-redhat · Nov 25, 2019 · 0b27b64 · 0b27b64
1 parent d3f9879
commit 0b27b64
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/pkg/crc/machine/driver_darwin.go b/pkg/crc/machine/driver_darwin.go
@@ -3,6 +3,7 @@ package machine
 import (
 	"github.com/code-ready/crc/pkg/crc/constants"
 	"github.com/code-ready/crc/pkg/crc/errors"
+	"github.com/code-ready/crc/pkg/crc/output"
 	crcos "github.com/code-ready/crc/pkg/os"
 
 	"github.com/code-ready/crc/pkg/crc/machine/config"
@@ -39,6 +40,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} {
 	switch machineConfig.VMDriver {
 
 	case "virtualbox":
+		output.Outln("Virtualbox support is deprecated and will be removed in the next release.")
 		driver = virtualbox.CreateHost(machineConfig)
 	case "hyperkit":
 		driver = hyperkit.CreateHost(machineConfig)

diff --git a/pkg/crc/machine/driver_windows.go b/pkg/crc/machine/driver_windows.go
@@ -2,6 +2,7 @@ package machine
 
 import (
 	"github.com/code-ready/crc/pkg/crc/errors"
+	"github.com/code-ready/crc/pkg/crc/output"
 	crcos "github.com/code-ready/crc/pkg/os"
 
 	"github.com/code-ready/crc/pkg/crc/machine/config"
@@ -37,6 +38,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} {
 	switch machineConfig.VMDriver {
 
 	case "virtualbox":
+		output.Outln("Virtualbox support is deprecated and will be removed in the next release.")
 		driver = virtualbox.CreateHost(machineConfig)
 	case "hyperv":
 		driver = hyperv.CreateHost(machineConfig)

diff --git a/pkg/crc/services/dns/dns_windows.go b/pkg/crc/services/dns/dns_windows.go
@@ -7,7 +7,6 @@ import (
 	"time"
 
 	"github.com/code-ready/crc/pkg/crc/errors"
-	"github.com/code-ready/crc/pkg/crc/output"
 	"github.com/code-ready/crc/pkg/crc/services"
 
 	winnet "github.com/code-ready/crc/pkg/os/windows/network"
@@ -18,8 +17,7 @@ import (
 func runPostStartForOS(serviceConfig services.ServicePostStartConfig, result *services.ServicePostStartResult) (services.ServicePostStartResult, error) {
 	// bailout for Virtualbox
 	if serviceConfig.DriverName == "virtualbox" {
-		output.Outln("Please follow instructions in the documentation about setting hostnames for Virtualbox.")
-		result.Success = true
+		result.Success = false
 		return *result, nil
 	}