-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve autocomplete #44
Comments
At least that's my interpretation based on: dnaapler/src/dnaapler/utils/processing.py Lines 78 to 82 in 6a672fd
But correct me if I am wrong, I can take a closer look at the logs |
I chose to have a strict match of the start codon in dnaapler to ensure the rotation does not interrupt a CDS, but I agree this would be a good feature. I will aim to add this in the next week or two. It will require some refactoring and so isn't trivial but shouldn't be too hard. George |
Hi @simone-pignotti , I've made your suggestion the default within all BLAST based commands in dnaapler (aka it will take the top row of the blastx table, and if it the matching alignment doesn't start with a start codon, it will run pyrodigal to find the CDS with the most overlap). Available in v0.4.0 George |
Wonderful, thank you so much @gbouras13! |
Hi @gbouras13, I have encountered a case where there are multiple blast hits with very low evalue (1e-180) that just happened to miss the start of the target by few residues, so they were discarded and a random gene ("nearest" option) was used instead.
I think that in those cases it would be best to use the ORF that overlaps the best blast hit, and even make this the default when
--autocomplete
is not specified. What do you think?The text was updated successfully, but these errors were encountered: