Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_bearings_distribution: defer weighting to np.histogram #1147

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Mar 13, 2024

closes #1143

TODO:

  • pass CI

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (12dbb6c) to head (6ca5352).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1147   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          24       24           
  Lines        2432     2436    +4     
=======================================
+ Hits         2383     2387    +4     
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhimmel dhimmel marked this pull request as ready for review March 13, 2024 02:30
Copy link
Owner

@gboeing gboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhimmel looks good. Just one comment to simplify a bit of the code.

osmnx/bearing.py Outdated Show resolved Hide resolved
@gboeing gboeing merged commit 016d3ca into gboeing:v2 Mar 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants