"Excluded" option #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed there's an "excluded" option set to an empty string and then never used.
I'm not really sure what was the purpose of it, but I found myself in the need of a way to specify elements to which the smooth-scroll would not be applied, e.g. I want to have smooth scrolling on the document, but not on some specific overflowing elements inside.
Therefore I think the option can be used to specify a CSS3 selector to match elements that should not be affected by the script.
P.S. The reason I want to disable the script for certain elements is that, once you scroll down and reach the end of the overflowing element's contents, the page starts scrolling, which is not actually how it works with the script enabled. I'm not sure if it's a Chrome or smooth-scroll bug, or if it's a bug at all.
Nevertheless, here's a quick 'n dirty solution for my issue, that I think others could benefit as well.