Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHA1 function usage makes library DB dependent #19

Closed
RomeroMsk opened this issue Mar 1, 2017 · 1 comment
Closed

SHA1 function usage makes library DB dependent #19

RomeroMsk opened this issue Mar 1, 2017 · 1 comment

Comments

@RomeroMsk
Copy link

By using SHA1() function in queries in PDOStorage class you make this library DB dependent. For example, PostgreSQL doesn't have such function built-in.
Could you please rework this class to calculate the hash on PHP side?
@dampfklon dampfklon mentioned this issue Mar 5, 2017
Merged
@RomeroMsk RomeroMsk mentioned this issue Mar 7, 2017
Closed
gbirke added a commit that referenced this issue Mar 15, 2017
@gbirke
Move hashing to storage class
11c141f 
Hashing in PHP has the advantage of bing independent from SQL dialects
for generating hashes. Hash functions might not be available on all DB
platforms.

This solves issue #19

Updated coding standard lib to allow concatened multiline strings.
@RomeroMsk
Copy link
Author

Tested, works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RomeroMsk