Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files #14

Merged
merged 11 commits into from
Mar 16, 2022
Merged

Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files #14

merged 11 commits into from
Mar 16, 2022

Commits on Mar 15, 2022

  1. Add play-for functionality 

    Signed-off-by: Geoffrey Biggs <[email protected]>
    @gbiggs @agalbachicar
    gbiggs authored and agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    cd7cbfa View commit details
    Browse the repository at this point in the history

  2. Add play-for to the CLI 

    Signed-off-by: Geoffrey Biggs <[email protected]>
    @gbiggs @agalbachicar
    gbiggs authored and agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    874d656 View commit details
    Browse the repository at this point in the history

  3. Adds playback_duration to PlayOptions.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    1ed5f6b View commit details
    Browse the repository at this point in the history

  4. Changes from PlayFor to Play srv message and changes start_offset and… 

    … playback_duration.
    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    0fa90ff View commit details
    Browse the repository at this point in the history

  5. Restores play_for tests.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f73f584 View commit details
    Browse the repository at this point in the history

  6. Removes extra SubscriptionManager methods.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    34f27ae View commit details
    Browse the repository at this point in the history

  7. Solves comment about extra sent message.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    cd25848 View commit details
    Browse the repository at this point in the history

  8. Reorders code and comment.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f33b7d6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'gbiggs/play_for' into agalbachicar/gbiggs/play_for

    @agalbachicar
    agalbachicar authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    664ec3e View commit details
    Browse the repository at this point in the history

  10. Removes the SKIP_TEST flag.

    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    0afd287 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'agalbachicar/gbiggs/play_for' of github.com:agalbachica… 

    …r/rosbag2 into agalbachicar/gbiggs/play_for
    @agalbachicar
    agalbachicar committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    6c8931b View commit details
    Browse the repository at this point in the history