Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map basisOfRecord *DNA values to MaterialSample #538

Closed
timrobertson100 opened this issue Jun 3, 2021 · 2 comments
Closed

Map basisOfRecord *DNA values to MaterialSample #538

timrobertson100 opened this issue Jun 3, 2021 · 2 comments

Comments

@timrobertson100
Copy link
Member

As requested by @elywallis here we should map basisOfRecord values of environmentalDNA and genomicDNA to MaterialSample instead of UNKNOWN.

This is to improve the filtering capabilities as an interim solution, while the wider discussion is ongoing.
@timrobertson100 timrobertson100 mentioned this issue Jun 3, 2021
Open
MattBlissett added a commit to gbif/parsers that referenced this issue Jun 3, 2021
@MattBlissett
BasisOfRecord values for environmental DNA and genomic DNA.
d1c9494 
Plus a few noticed from the current data.

See gbif/pipelines#538
See gbif/gbif-api#84
@MattBlissett
Copy link
Member

MattBlissett commented Jun 3, 2021 •
edited
Loading

See https://github.com/gbif/parsers/blob/master/src/main/resources/dictionaries/parse/basisOfRecord.tsv#L90 for the new mapping, I have added environmental dna and genomic dna (casing, spaces, _ etc don't matter).

We currently have this many occurrences for these values:

1171901 UNKNOWN EnvironmentalDNA
118835  UNKNOWN GenomicDNA

No others in currently-indexed data have "DNA" in the provided basis of record, @elywallis, are you aware of any more values we should map to MaterialSample?

@marcos-lg
Copy link
Contributor

Closing it as it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timrobertson100 @MattBlissett @marcos-lg