Address PR Comments

Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna · Oct 15, 2024 · 2df2683 · 2df2683
1 parent cc11f7e
commit 2df2683
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/server/src/internalClusterTest/java/org/opensearch/cluster/settings/ClusterSettingsIT.java b/server/src/internalClusterTest/java/org/opensearch/cluster/settings/ClusterSettingsIT.java
@@ -431,12 +431,26 @@ public void testThreadPoolSettings() {
             assertEquals(ex.getCause().getMessage(), "core threadpool size cannot be greater than max");
         }
 
-        // Scaling threadpool - happy case
+        // Scaling threadpool - Max value lesser than default value of 4
+        try {
+            client().admin()
+                .cluster()
+                .prepareUpdateSettings()
+                .setTransientSettings(Settings.builder().put("cluster.thread_pool.generic.max", "1").build())
+                .get();
+            fail("bogus value");
+        } catch (IllegalArgumentException ex) {
+            assertEquals(ex.getCause().getMessage(), "core threadpool size cannot be greater than max");
+        }
+
+        // Scaling threadpool - happy case - transient overrides persistent
         ClusterUpdateSettingsResponse clusterUpdateSettingsResponse = client().admin()
             .cluster()
             .prepareUpdateSettings()
-            .setTransientSettings(Settings.builder().put("cluster.thread_pool.snapshot.max", "1").build())
-            .setPersistentSettings(Settings.builder().put("cluster.thread_pool.snapshot.max", "5").build())
+            .setTransientSettings(
+                Settings.builder().put("cluster.thread_pool.snapshot.core", "2").put("cluster.thread_pool.snapshot.max", "2").build()
+            )
+            .setPersistentSettings(Settings.builder().put("cluster.thread_pool.snapshot.max", "1").build())
             .get();
         assertTrue(clusterUpdateSettingsResponse.isAcknowledged());