Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-genesis transition #304

Closed
wants to merge 22 commits into from
Closed

post-genesis transition #304

wants to merge 22 commits into from

Commits on Mar 26, 2024

  1. post-genesis transition

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ad3281f View commit details
    Browse the repository at this point in the history

  2. quell linter issue

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b7381c0 View commit details
    Browse the repository at this point in the history

  3. support Transition post tree in conversion

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d49cbd6 View commit details
    Browse the repository at this point in the history

  4. Refactor transition post genesis (#311) 

    * rewrite per-block conversion pointer management

* remove unused method

* fix: a branch that can verge at genesis or post genesis (#314)

* fix: import cycle in conversion refactor (#315)

* fix shadowfork panic in OpenStorageTrie
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a7bc86f View commit details
    Browse the repository at this point in the history

  5. fix OpenStorageTrie: return an error instead of panicking if the acco… 

    …unt tree not a verkle tree (#321)
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0582870 View commit details
    Browse the repository at this point in the history

  6. add a switch to force proof in blocks (#322) 

    * add a switch to force proof in blocks

* activate switch

* fix switch type
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3e5b4b7 View commit details
    Browse the repository at this point in the history

  7. add switch to override the stride of the overlay conversion (#323) 

    * add switch to override the stride of the overlay conversion

* set a default stride of 10k
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8bfaaa0 View commit details
    Browse the repository at this point in the history

  8. add a few traces for relaunch

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    677e66e View commit details
    Browse the repository at this point in the history

  9. add missing step in the chain of setting the override for overlay stride

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    28eee60 View commit details
    Browse the repository at this point in the history

  10. fix: save and load transition state for block processing (#324) 

    * fix: save and load transition state for block processing

* log whether the tree is verkle in LoadTransitionState

* fix: ensure the transition is marked as started in insertChain

* dump saved address

* fix nil pointer panic

* remove stacktrace that is no longer useful

* fix a panic

* fix build

* check: copy current account address BEFORE it's saved

* mandatory panic fix

* Remove debug fmt.Println

* more cleanup + comments
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3cbf601 View commit details
    Browse the repository at this point in the history

  11. fix: ensure StorageProcessed is properly recovered

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7e86b80 View commit details
    Browse the repository at this point in the history

  12. add traces for gas pool overflow

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6a255d0 View commit details
    Browse the repository at this point in the history

  13. cmd/{geth, utils}: add a command to clear verkle costs (#326) 

    * cmd/{geth, utils}: add a command to clear verkle costs

fix:  boolean issue

fix: load finalization state in FinalizeAndAssemble (#340)

* Conversion and TransitionTrie fixes (#346)

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* remove old comment

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

* trace cleanup

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
    @gballet @jsign
    gballet and jsign committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9b54f29 View commit details
    Browse the repository at this point in the history

  14. fix: check for nil override in NewBlockChain (#357)

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6841063 View commit details
    Browse the repository at this point in the history

  15. fix rebase issue

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a4c556d View commit details
    Browse the repository at this point in the history

  16. fix a few rebase issues

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a774d16 View commit details
    Browse the repository at this point in the history

  17. add debug traces

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1784337 View commit details
    Browse the repository at this point in the history

  18. fix: assume that having to create a new transaction state mean it has… 

    …n't happened.

This is a workaround, because it will always be false when restarting a node
that has started the transition but not necessarily completed it.
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ff36168 View commit details
    Browse the repository at this point in the history

  19. add logs to debug shadowfork

    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a641947 View commit details
    Browse the repository at this point in the history

  20. persist conversion state to db and use an LRU cache for active transi… 

    …tion states (#375)

* persist conversion state to db

* fix: don't recreate LRU when writing state

* opt: only write state to db if not already present in LRU

* fix: rlp can't encode TransitionState

* fix: use gob because binary.Write does not support structs 🤦‍♂️

* fix: nil pointer panic

* add logs to debug shadowfork

* no such thing as not enough traces

* ditto

* fix stupid bug

* add a comment for readability

* add more traces

* Lock the state transition during conversion (#384)

* heavy handed approach: lock the state transition during conversion

* also lock transition state loading/unloading

* reduce logs verbosity

* add conversion test to workflow (#386)

* add conversion test to workflow

* mandatory -f switch fix in rm

* forgot & at the end of the geth command

* remove incorrect kill

* add debug traces

* add an overlay stride

* fix typo

* Apply suggestions from code review
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7a3bb67 View commit details
    Browse the repository at this point in the history

  21. eth: add debug_conversionStatus RPC call (#392) 

    * eth: add debug_conversionStatus RPC call

* add debug trace4s

* Apply suggestions from code review

* export started/ended fields
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    afc364b View commit details
    Browse the repository at this point in the history

  22. fix post-verge sync (#404) 

    * fix post-verge sync

* review: fix truncated comment
    @gballet
    gballet committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    bb3a39d View commit details
    Browse the repository at this point in the history