save overlay conversion iterator pointers at each block #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Oct 26, 2023
| @@ -64,37 +64,37 @@ type Database interface { | |||
| // TrieDB retrieves the low level trie database used for data storage. | |||
| TrieDB() *trie.Database | |||
|
|
|||
| StartVerkleTransition(originalRoot, translatedRoot common.Hash, chainConfig *params.ChainConfig, cancunTime *uint64) | |||
| StartVerkleTransition(originalRoot common.Hash, chainConfig *params.ChainConfig, cancunTime *uint64, root common.Hash) | |||
There was a problem hiding this comment.
TODO: see if originalRoot and root can be merged into a single value. It should be possible as the verkle transition is only started at a given block height, which is the one at the fork.
gballet
commented
Oct 26, 2023
core/state/database.go
Outdated
| CurrentAccountAddress: map[common.Hash]*common.Address{}, | ||
| CurrentSlotHash: map[common.Hash]common.Hash{}, | ||
| CurrentPreimageOffset: map[common.Hash]int64{}, started: map[common.Hash]bool{}, | ||
| ended: map[common.Hash]bool{}, |
There was a problem hiding this comment.
TODO check that the proper value will be set when transitioning at genesis
gballet
commented
Oct 26, 2023
core/state/database.go
Outdated
| CurrentSlotHash: map[common.Hash]common.Hash{}, | ||
| CurrentPreimageOffset: map[common.Hash]int64{}, | ||
| started: map[common.Hash]bool{}, | ||
| ended: map[common.Hash]bool{}, |
4 tasks
|
superseded by #304, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the shadow fork. It appeared, while performing the overlay transition with Kaustinen rebased on shapella, that the conversion at a slot after genesis got broken. Bugs happened because the transition was executed multiple times at the same block height, but the iterator pointers were not rewound.
This PR introduces per-block iterator pointers. More exactly, iterator pointers are related to the state root hash of the parent of the block that uses these iterators. If a block is reexecuted multiple times, then the pointers that are used will be initialized with how they were when that parent block was sealed.
The choice of linking the iterator pointers to the parent root hash instead of e.g. the slot number, comes from the fact that it's simpler to code. We might (probably will, in fact) change that after some refactoring, e.g. a rebase of the kaustinen branch on top of PBSS. Right now, this should be good enough for a reorg-less shadowfork.