Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update packages #12

wants to merge 3 commits into from

Conversation

fenichelar
Copy link
Contributor

@fenichelar fenichelar commented Oct 14, 2020 •
edited
Loading

Breaking change - release 2.0.0
Addresses all know vulnerabilities but requires node v10 or later. Node v8 and earlier are no longer supported so I think this is okay.

@coveralls
Copy link

coveralls commented Oct 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 98

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 24: 0.0%
Covered Lines: 38
Relevant Lines: 38
💛 - Coveralls

@fenichelar
Copy link
Contributor Author

@gazoakley Would you be able to merge this? If fixes a high severity vulnerability in node-forge.

@fenichelar
Copy link
Contributor Author

@gazoakley Do you want me to bump the version in package.json and package-lock.json to v2.0.0 due to the breaking change of requiring Node.js v10 or later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenichelar @coveralls