Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: tear down a stale append pipeline before proxying #414

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Jan 16, 2025

This can happen if we were primary, but have been re-assigned as a replica without an observed cancellation of our assignment in between.

We must tear down the stale pipeline to release replica spools before we return it.


This change is Reviewable

This can happen if we were primary, but have been re-assigned as a
replica without an observed cancellation of our assignment in between.

We must tear down the stale pipeline to release replica spools before we
return it.
@jgraettinger jgraettinger requested a review from psFried January 16, 2025 22:30
Copy link
Contributor

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jgraettinger jgraettinger merged commit 9f78463 into master Jan 16, 2025
1 check passed
@jgraettinger jgraettinger deleted the johnny/release-pipeline branch January 16, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants