Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Pose(), PoseFrame() functions from sdf10 #308

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

scpeters
Copy link
Member

Several *Pose() and *PoseFrame() functions were deprecated from DOM objects in libsdformat9 by bitbucket pr 598 and bitbucket pr 599. This removes them and updates the migration guide with the changes from #244 and #276 as well.

@scpeters scpeters requested a review from azeey June 27, 2020 13:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2020

Codecov Report

Merging #308 into sdf10 will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf10     #308      +/-   ##
==========================================
+ Coverage   86.83%   87.69%   +0.86%     
==========================================
  Files          59       59              
  Lines        9138     9048      -90     
==========================================
  Hits         7935     7935              
+ Misses       1203     1113      -90     
Impacted Files Coverage Δ
src/Actor.cc 84.79% <ø> (+2.40%) ⬆️
src/Camera.cc 83.51% <ø> (+2.26%) ⬆️
src/Collision.cc 100.00% <ø> (+12.04%) ⬆️
src/Joint.cc 98.03% <ø> (+6.01%) ⬆️
src/Light.cc 92.63% <ø> (+4.63%) ⬆️
src/Link.cc 97.67% <ø> (+5.36%) ⬆️
src/Model.cc 88.74% <ø> (+3.68%) ⬆️
src/Sensor.cc 82.07% <ø> (+3.14%) ⬆️
src/Visual.cc 100.00% <ø> (+8.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83eb29e...130677d. Read the comment docs.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters merged commit 50406fd into gazebosim:sdf10 Jun 30, 2020
@scpeters scpeters deleted the rm_deprecated_pose_frame branch June 30, 2020 17:24
scpeters added a commit to scpeters/sdformat that referenced this pull request Jun 30, 2020
…#308)

* Remove all deprecated *PoseFrame() APIs
* Remove deprecated Pose(), SetPose() APIs
* Migration guide: update per gazebosim#244, gazebosim#276
* Changelog for gazebosim#308.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit to scpeters/sdformat that referenced this pull request Jun 30, 2020
…#308)

* Remove all deprecated *PoseFrame() APIs
* Remove deprecated Pose(), SetPose() APIs
* Migration guide: update per gazebosim#244, gazebosim#276
* Changelog for gazebosim#308.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request Jul 2, 2020
* Remove all deprecated *PoseFrame() APIs
* Remove deprecated Pose(), SetPose() APIs
* Migration guide: update per #244, #276
* Changelog for #308.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants