Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SetHeightMap and Heighmap to Geometry Python binding #1440

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 19, 2024

🎉 New feature

Closes #1439

Summary

Related with this issue #1439

Test it

colcon test --merge-install --event-handlers console_direct+ --packages-select sdformat14 --ctest-args -R pyGeometry_TEST

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.47%. Comparing base (ff9b3ad) to head (5b3d531).
Report is 43 commits behind head on sdf14.

Current head 5b3d531 differs from pull request most recent head 2cb62e2

Please upload reports for the commit 2cb62e2 to get more accurate results.

Files Patch % Lines
python/src/sdf/pyGeometry.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            sdf14    #1440      +/-   ##
==========================================
+ Coverage   92.42%   92.47%   +0.05%     
==========================================
  Files         134      135       +1     
  Lines       17751    18075     +324     
==========================================
+ Hits        16406    16715     +309     
- Misses       1345     1360      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahcorde ahcorde requested a review from iche033 June 27, 2024 11:23
@scpeters scpeters merged commit 0ecfcc3 into sdf14 Jun 28, 2024
12 checks passed
@scpeters scpeters deleted the ahcorde/sdf14/geometry_heightamp branch June 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Geometry Python object lacks API's for Heightmaps
3 participants