-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <voxel_resolution> SDF element to <convex_decomposition> #1403
Conversation
Signed-off-by: Ian Chen <[email protected]>
sdf/1.12/mesh_shape.sdf
Outdated
@@ -12,6 +12,9 @@ | |||
<element name="max_convex_hulls" type="unsigned int" default="16" required="0"> | |||
<description>Maximum number of convex hulls to decompose into. This sets the maximum number of submeshes that the final decomposed mesh will contain.</description> | |||
</element> | |||
<element name="voxel_resolution" type="unsigned int" default="200000" required="0"> | |||
<description>Voxel resolution to use for representing the mesh before decomposition. Applicable only to voxel based convex decomposition methods.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the units of the voxel resolution parameter? is it a volumetric density or a number of elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated description to say that resolution is the number of voxels. 5416ba5
Signed-off-by: Ian Chen <[email protected]>
…nto voxel_resolution
🎉 New feature
Summary
Adds a new
<voxel_resolution>
parameter. This is only applicable to voxel based convex decomposition methods.See below for alternative proposals that I have considered. I'm open to suggestions.
Alternatives considered
<resolution>
instead of<voxel_resolution>
so that it's applicable to a wider range of convex decomposition methods. e.g.One example of non-voxel based method is the CoACD method which offers a couple resolution configuration params (
resolution
andmanifold preprocess resolution
).<bullet>
,<ode>
, and<dart>
specific params):This PR chose an approach that's kind of half way between the 2 above alternatives. I added the
<voxel_resolution>
SDF element to be more explicit in limiting this element to voxel based methods but not overly specific to a particular convex decomposition library.One option for extending the spec in the future would be:
Test it
Run the tests:
UNIT_Mesh_TEST
andINTEGRATION_geometry_dom
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.