Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python wrapper to ConvexDecomposition #1398

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 9, 2024

🦟 Bug fix

Included Python wrappers. Not included in this PR https://github.com/gazebosim/sdformat/pull/1382/files#diff-b9300f518b4c9843b5485c6c923d70f57bc0d6d7675d86e8f12c1438ca8d091a

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from iche033 April 9, 2024 09:01
@ahcorde ahcorde self-assigned this Apr 9, 2024
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 9, 2024
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@ahcorde ahcorde merged commit c8fbdbe into main Apr 9, 2024
8 checks passed
@ahcorde ahcorde deleted the ahcorde/main/convex_decomposition_python branch April 9, 2024 20:45
iche033 added a commit that referenced this pull request Apr 10, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
iche033 added a commit that referenced this pull request Apr 10, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants