Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow: use checkout v3 in jammy #1245

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 3, 2023

🦟 Bug fix

Part of gazebo-tooling/release-tools#862.

Summary

Version v2 of the actions/checkout workflow is deprecated, so switch to v3.

Follow-up to #1225 that missed jammy when merged forward.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero March 3, 2023 19:44
@scpeters scpeters requested a review from azeey as a code owner March 3, 2023 19:44
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1245 (5726937) into sdf12 (8d89537) will not change coverage.
The diff coverage is n/a.

❗ Current head 5726937 differs from pull request most recent head e2bbc6c. Consider uploading reports for the commit e2bbc6c to get more accurate results

@@           Coverage Diff           @@
##            sdf12    #1245   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          79       79           
  Lines       13090    13090           
=======================================
  Hits        12047    12047           
  Misses       1043     1043           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

Windows failure is unrelated, I'm going to merge.

@mjcarroll mjcarroll merged commit 3a13dc5 into sdf12 Mar 3, 2023
@mjcarroll mjcarroll deleted the scpeters/checkout_v2_jammy branch March 3, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants