Added HasLensProjection #1203
Merged
Added HasLensProjection #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
8 tasks
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
@azeey Let me know if I should backport this to |
|
What's the motivation for this PR? Why do we need to know if the projection is custom or default? |
This is the motivation gazebosim/gz-sensors#289 |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1203 +/- ##
=======================================
Coverage 87.52% 87.53%
=======================================
Files 124 124
Lines 16124 16143 +19
=======================================
+ Hits 14113 14131 +18
- Misses 2011 2012 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
friendly ping @azeey |
azeey
approved these changes
Nov 21, 2022
If it's not too much effort, yes please. |
ahcorde
added a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
9 tasks
ahcorde
added a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
this looks like a parallel of the |
scpeters
pushed a commit
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
9 tasks
iche033
added a commit
to gazebosim/gz-sensors
that referenced
this pull request
Feb 14, 2023
This PR allows users to specify custom camera projection using the <projection> values from SDF (in addition to <instrinscs>, see #293). Also bumped sdformat dep version as it need gazebosim/sdformat#1203 --------- Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alejandro Hernández Cordero [email protected]
🎉 New feature
Summary
Added
HasLensProjectionto Camera class, this PR is connected with a PR ingz-sensors.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.