Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default camera_info_topic value to __default__ #1201

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 16, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Related with this comment gazebosim/gz-sensors#285 (comment)

Summary

Changed default value of camera topic to __default__ like the other topic names and strings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Nov 16, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1201 (4a93c54) into sdf9 (7c89e64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             sdf9    #1201   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          63       63           
  Lines       10082    10084    +2     
=======================================
+ Hits         8907     8909    +2     
  Misses       1175     1175           
Impacted Files Coverage Δ
src/Camera.cc 83.48% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from iche033 November 17, 2022 00:08
@ahcorde ahcorde merged commit dc88f3a into sdf9 Nov 17, 2022
@ahcorde ahcorde deleted the ahcorde/9/9/camera_info_topic_default branch November 17, 2022 08:42
@iche033 iche033 mentioned this pull request Feb 27, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants