Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to pass extra parameters to ros_gz_bridge #628

Open
wants to merge 7 commits into
base: ros2
Choose a base branch
from
Open

Add a way to pass extra parameters to ros_gz_bridge #628

wants to merge 7 commits into from
+110 −90

Commits on Oct 30, 2024

  1. Add bridge_params argument to ros_gz_bridge.launch.py 

    Allows one to pass extra arguments to ros_gz_bridge

Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9601baf View commit details
    Browse the repository at this point in the history

  2. Pass tests 

    Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ebcb283 View commit details
    Browse the repository at this point in the history

  3. Fix errors that happen when no parameters are passed 

    Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c6f90c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'ros2' into bridge-params

    @Amronos
    Amronos authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    407c48c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. For ros_gz_bridge make the launch file use the action instead of the … 

    …action using the launch file

Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    fc77eff View commit details
    Browse the repository at this point in the history

  2. Fix style errors 

    Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    19c7643 View commit details
    Browse the repository at this point in the history

  3. Fix errors that happen when an empty dictionary is passed to bridge_p… 

    …arams

Signed-off-by: Aarav Gupta <[email protected]>
    @Amronos
    Amronos committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8b47b82 View commit details
    Browse the repository at this point in the history