-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: override_timestamps_with_wall_time
parameter (backport #562)
#584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imestamps_with_wall_time is set to true (#562) Signed-off-by: Rein Appeldoorn <[email protected]> (cherry picked from commit 6daea2c) # Conflicts: # ros_gz_bridge/src/factory.hpp
Cherry-pick of 6daea2c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
Signed-off-by: Rein Appeldoorn <[email protected]>
ahcorde
approved these changes
Aug 29, 2024
Thanks! |
It seems a new release was created just before this was merged. Would it be possible to kick off a new jazzy release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #546
Summary
Stamp all outgoing headers with the wall time if parameter
override_timestamps_with_wall_time
is set totrue
.Test it
Start the bridge with the additional parameter
override_timestamps_with_wall_time
set totrue
. Note that the outgoing messages have the wall time stamp and not the gazebo time stamp.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.This is an automatic backport of pull request #562 done by [Mergify](https://mergify.com).