Launch gz_spawn_model from xml #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Launch file for the bridge Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Launch file for the bridge Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
…_node_composition Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
azeey
reviewed
May 22, 2024
Comment on lines
36
to
47
| world: SomeSubstitutionsType, | ||
| file: SomeSubstitutionsType, | ||
| xml_string: SomeSubstitutionsType, | ||
| topic: SomeSubstitutionsType, | ||
| name: SomeSubstitutionsType, | ||
| allow_renaming: SomeSubstitutionsType, | ||
| x: SomeSubstitutionsType, | ||
| y: SomeSubstitutionsType, | ||
| z: SomeSubstitutionsType, | ||
| roll: SomeSubstitutionsType, | ||
| pitch: SomeSubstitutionsType, | ||
| yaw: SomeSubstitutionsType, |
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…s_gz into gz_sim_ros_node_composition
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
requested changes
May 23, 2024
| z="$(var z)" | ||
| roll="$(var roll)" | ||
| pitch="$(var pitch)" | ||
| yaw="$(var yaw)" |
There was a problem hiding this comment.
This looks wrong, isn't it?
Suggested change
| yaw="$(var yaw)" | |
| yaw="$(var yaw)"> |
There was a problem hiding this comment.
Typo fixed in 04c9dc8.
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
approved these changes
May 24, 2024
Amronos
pushed a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 18, 2024
Spawn models from XML. Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #552
Summary
This patch lets you spawn a gz sim model from an XML file.
How to test it?
Launch gz sim:
Hit play.
Use the provided
gz_spawn_model.launchto spawn a vehicle (changefileaccordingly):A vehicle should be loaded into the scene.
Confirm that no container has been created:
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.