Undeprecate use of commandline flags #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
requested changes
Jan 29, 2024
mjcarroll
approved these changes
Jan 29, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Done in 7aa366b |
ahcorde
approved these changes
Jan 30, 2024
caguero
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm writing a migration guide for Gazebo classic users and using the command line flags since that's what's available in Humble. It's also very closely matched with
gazebo_ros_pkgsso the migration is a lot easier if we keep the flags. I think it would be best to keep these flags, at least for another ROS release cycle.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.