Added messages for 2D Bounding Boxes to ros_gz_bridge #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Oct 30, 2023
| ignition::msgs::Vector2d min_corner = box.min_corner(); | ||
| ignition::msgs::Vector2d max_corner = box.max_corner(); | ||
|
|
||
| auto id = ros_msg.results.at(0).hypothesis.class_id; |
There was a problem hiding this comment.
we should check here if there is any values availables in the results array.
There was a problem hiding this comment.
Thanks for the quick review! Should we maybe print a warning when there is nothing in the results array as it is a malformed message? If I am not mistaken, the id in the GZ message will be 0 if it is not explicitly set. Or is there any other way of conveying "None-ness" here?
…2DBox_V messages Signed-off-by: wittenator <[email protected]>
Integrated first batch of suggestions Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: wittenator <[email protected]>
Signed-off-by: wittenator <[email protected]>
ahcorde
approved these changes
Nov 9, 2023
ahcorde
pushed a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: wittenator <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Nov 21, 2023
Signed-off-by: wittenator <[email protected]>
9 tasks
ahcorde
added a commit
that referenced
this pull request
Nov 21, 2023
Signed-off-by: wittenator <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #457
Summary
I added the bridging of Detection2D and Detection2DArray to AnnotatedAxisAligned2DBox and AnnotatedAxisAligned2DBox_V and vice versa.
Test it
WIP
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸