Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expectations to subprocess test #155

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Minor improvements to INTEGRATION_subprocess_TEST

Summary

This adds expectations to the subprocess test instead of just checking that cout/cerr are not empty. It also adds streaming of variable values if expectations fail.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This adds expectations to the subprocess test instead
of just checking that cout/cerr are not empty. It also
adds streaming of variable values if expectations fail.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner October 14, 2024 11:56
@scpeters scpeters merged commit 10b3946 into gz-utils3 Oct 16, 2024
13 checks passed
@scpeters scpeters deleted the scpeters/subprocess_test branch October 16, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants