Add EoL and use SetConsoleSinkLevel #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
SetConsoleSinkLevel()
to only change the verbosity level of the console.This is the result we should see in the console:
And this is the result we should see in
/tmp/my_log.txt
:If we change the verbosity level using the original call
logger.RawLogger().set_level(spdlog::level::trace);
the result is confusing because the console only shows:The reason for this is because we have a logger level set to
trace
and the console sink levels set toerr
inLogger.cc
.spdlog
seems to choose the verbosity with higher priority between sinks and logger.Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.