Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: build and test subprocess functionality #123

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

When subprocess functionality was introduced, it wasn't tested with bazel builds. This fixes that.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from azeey as a code owner January 31, 2024 14:36
@mjcarroll mjcarroll self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56b4f13) 80.98% compared to head (674f0e1) 80.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-utils2     #123   +/-   ##
==========================================
  Coverage      80.98%   80.98%           
==========================================
  Files              8        8           
  Lines            384      384           
==========================================
  Hits             311      311           
  Misses            73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit f928192 into gz-utils2 Feb 6, 2024
13 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/include_subprocess_h branch February 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants