Remove duplicated functionality from test_config #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-transport12 #457 +/- ##
===============================================
Coverage 87.29% 87.29%
===============================================
Files 60 60
Lines 5211 5211
===============================================
Hits 4549 4549
Misses 662 662 |
Signed-off-by: Michael Carroll <[email protected]>
ahcorde
approved these changes
Nov 2, 2023
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/test_cleanup
branch
from
97378e9
to
798e7f6
Compare
mjcarroll
added a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gz::utils::envfamily of functions rather than the OS equivalents (which are also missing on Windows)gz::utilsdisable macros rather than custom ones.std::filesystemlogic, as we are only supporting c++17 and above here.