Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configure.bat #83

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Remove configure.bat #83

merged 1 commit into from
Apr 14, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

That file shouldn't be needed anymore. Windows CI says

"DEPRECATED configure.bat file detected. It should be removed from upstream sources"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Remove configure.bat
974e2ab 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the Windows Windows support label Apr 14, 2022
@chapulina chapulina requested a review from caguero as a code owner April 14, 2022 20:42
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 14, 2022
scpeters
scpeters approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be fine since gazebo-tooling/release-tools#537 was merged

@scpeters scpeters merged commit 73acac7 into ign-tools1 Apr 14, 2022
@scpeters scpeters deleted the chapulina/1/old_files branch April 14, 2022 20:58
@scpeters
Copy link
Member

actually, we've done this before: gazebo-tooling/release-tools#588 (comment)

I think we need to restore configure.bat for the sake of gazebo11's windows CI

@scpeters
Copy link
Member

actually, we've done this before: ignition-tooling/release-tools#588 (comment)

I think we need to restore configure.bat for the sake of gazebo11's windows CI

Build Status https://build.osrfoundation.org/job/gazebo-ci-gazebo11-windows7-amd64/140/

scpeters added a commit that referenced this pull request Apr 15, 2022
@scpeters
Revert "Remove configure.bat (#83)"
4d2f47c 
This reverts commit 73acac7.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Apr 15, 2022
Merged
7 tasks
@scpeters
Copy link
Member

actually, we've done this before: ignition-tooling/release-tools#588 (comment)

I think we need to restore configure.bat for the sake of gazebo11's windows CI

#84

scpeters added a commit that referenced this pull request Apr 15, 2022
@scpeters
Revert "Remove configure.bat (#83)" (#84)
1436de9 
This reverts commit 73acac7.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @scpeters