Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install ruby-ronn in CI #80

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to #53, needed by #79

Summary

The ruby-ronn package isn't used anymore, as noted in #53, but it was still being installed in our CI. There's an error installing it in jammy in #79, so just remove it from packages.apt to complete the work of #53.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from caguero as a code owner March 15, 2022 19:07
@scpeters scpeters changed the title Don't install ruby-runn in CI Don't install ruby-ronn in CI Mar 15, 2022
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Mar 15, 2022
@chapulina chapulina merged commit 2638a40 into gazebosim:ign-tools1 Mar 15, 2022
@scpeters scpeters deleted the no_ronn_dep branch March 15, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants