Fix visibility macro names when used by a different component (Windows)

[j-rivero]

The PR solves a critical problem: when building a new component (new shared object) the visibility keyword can not be the same than a library it links to. This translated means: our systems and components can not use IGNITION_GAZEBO_VISIBLE but the custom name created by ign-cmake in the form of IGNITION_GAZEBO_${COMPONENT_NAME}_VISIBLE. Otherwise there is a nice list of fanky linker errors all around.

[chapulina]

Wow I didn't know those macros even existed! I'm still not sure if the plugins need the visibility to be set though.

Codechecker is sad - otherwise the PR looks good to me.

  /github/workspace/include/ignition/gazebo/gui/Gui.hh:63:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/camera_video_recorder/CameraVideoRecorder.hh:44:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/joint_position_controller/JointPositionController.hh:75:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/logical_audio_sensor_plugin/LogicalAudioSensorPlugin.hh:132:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/multicopter_control/MulticopterVelocityControl.hh:149:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/multicopter_motor_model/MulticopterMotorModel.hh:37:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/optical_tactile_plugin/OpticalTactilePlugin.hh:69:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/systems/triggered_publisher/TriggeredPublisher.hh:157:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  Total errors found: 8

[azeey]

I'm still not sure if the plugins need the visibility to be set though.

Yeah, I don't think we want them to be visible. I would in fact vote for making them final classes.

[codecov]

Codecov Report

Merging #564 (7f9f1b7) into main (9246d67) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   77.57%   77.57%           
=======================================
  Files         211      211           
  Lines       11582    11582           
=======================================
  Hits         8985     8985           
  Misses       2597     2597           

Impacted Files	Coverage Δ
src/systems/apply_joint_force/ApplyJointForce.hh	100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh	100.00% <ø> (ø)
src/systems/buoyancy/Buoyancy.hh	100.00% <ø> (ø)
src/systems/contact/Contact.hh	100.00% <ø> (ø)
src/systems/detachable_joint/DetachableJoint.hh	100.00% <ø> (ø)
src/systems/diff_drive/DiffDrive.hh	100.00% <ø> (ø)
src/systems/joint_controller/JointController.hh	100.00% <ø> (ø)
...int_position_controller/JointPositionController.hh	100.00% <ø> (ø)
...stems/joint_state_publisher/JointStatePublisher.hh	100.00% <ø> (ø)
src/systems/lift_drag/LiftDrag.hh	100.00% <ø> (ø)
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9246d67...7f9f1b7. Read the comment docs.

[j-rivero]

I'm still not sure if the plugins need the visibility to be set though.

I've removed visibility from all plugins.

Yeah, I don't think we want them to be visible. I would in fact vote for making them final classes.

I agree. I would leave the change of moving them to final classes in a different PR.