Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update particle emitter tutorial #2585

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Update particle emitter tutorial #2585

merged 4 commits into from
Sep 4, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 3, 2024

🦟 Bug fix

Summary

Fixed the tutorial gist world file and moved it to gz-sim (gazebosim/gazebo_test_cases#1254 (comment)). The world file has one syntax error and it's also using outdated ignition syntaxes. Moving it to gz-sim so it's easier spot and maintain issues like these.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
tutorials/particle_tutorial.md Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde enabled auto-merge (squash) September 4, 2024 14:44
@ahcorde
Copy link
Contributor

ahcorde commented Sep 4, 2024

@osrf-jenkins run tests please!

@ahcorde ahcorde merged commit 5482778 into gz-sim9 Sep 4, 2024
10 checks passed
@ahcorde ahcorde deleted the particle_tutorial branch September 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants